Skip to content

Remove checkIfExists from interop file resolution#10942

Merged
delfiterradas merged 5 commits intonf-core:masterfrom
delfiterradas:bcl_demux
Mar 19, 2026
Merged

Remove checkIfExists from interop file resolution#10942
delfiterradas merged 5 commits intonf-core:masterfrom
delfiterradas:bcl_demux

Conversation

@delfiterradas
Copy link
Copy Markdown
Contributor

@delfiterradas delfiterradas commented Mar 17, 2026 •
edited
Loading

PR checklist

Required for nf-core/demultiplex#378

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@delfiterradas delfiterradas self-assigned this Mar 17, 2026
SPPearce
SPPearce reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you not want to check the files exist?

@delfiterradas
Copy link
Copy Markdown
Contributor Author

delfiterradas commented Mar 18, 2026

Why do you not want to check the files exist?

@SPPearce Because there is a test that fails in the demultiplex pipeline because the input doesn't have InterOp files. However, if we remove the check, multiqcsav can still work without this file and can create the report

@delfiterradas delfiterradas marked this pull request as ready for review March 18, 2026 14:12
@delfiterradas delfiterradas requested a review from SPPearce March 18, 2026 14:29
@delfiterradas delfiterradas marked this pull request as draft March 18, 2026 16:01
@delfiterradas delfiterradas marked this pull request as ready for review March 19, 2026 13:14
@delfiterradas delfiterradas added this pull request to the merge queue Mar 19, 2026
Merged via the queue into nf-core:master with commit f3086da Mar 19, 2026
18 checks passed
@delfiterradas delfiterradas deleted the bcl_demux branch March 19, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@delfiterradas delfiterradas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@delfiterradas @SPPearce